Add get_zones & create_zone REST API endpints #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgk
suggested changes
Aug 3, 2017
| @@ -1,9 +1,8 @@ | |||
| <?php | |||
| /** | |||
| * @packae Zoninator/Rest | |||
| * @package Zoninator/Rest | |||
| $this->translations = array( | ||
| self::ZONE_NOT_FOUND => __( 'Zone not found', 'zoninator' ), | ||
| self::INVALID_POST_ID => __( 'Invalid post id', 'zoninator' ), | ||
| self::INVALID_ZONE_ID => __( 'Zone not found', 'zoninator' ), | ||
| self::ZONE_ID_POST_ID_REQUIRED => __( 'post id and zone id required', 'zoninator' ), | ||
| ); | ||
|
|
||
| $this->add_route( 'zones' ) |
| ) ); | ||
| } | ||
|
|
||
| return new WP_REST_Response( $results, 200 ); |
There was a problem hiding this comment.
can also do return $this->ok( $results );
|
|
||
| $zone = $this->instance->get_zone( $result[ 'term_id' ] ); | ||
|
|
||
| return $this->created( $zone ); |
| $slug = $this->_get_param( $request, 'slug', '' ); | ||
| $description = $this->_get_param( $request, 'description', '', 'strip_tags' ); | ||
|
|
||
| $result = $this->instance->insert_zone( $slug, $name, array( 'description' => $description ) ); |
There was a problem hiding this comment.
Cool! Better if we split this into multiple lines (standard php practice on arrays with string keys, leave a comma in the array's end. Like so:
$result = $this->instance->insert_zone( $slug, $name, array(
'description' => $description,
) );| @@ -479,6 +547,11 @@ public function strip_slashes( $item ) { | |||
| return stripslashes( $item ); | |||
| } | |||
|
|
|||
| public function strip_tags( $item ) { | |||
| // see https://github.com/WP-API/WP-API/issues/1520 on why we do not use stripslashes directly | |||
There was a problem hiding this comment.
update comment to be about strip_tags :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
get_zones&create_zonesendpoints to the REST API.Endpoints
GET /zoninator/v1/zones( get a list with all zones )POST /zoniantor/v1/zones( create a new zone )Other
Changed permissions for
add_post_to_zonetoupdateas it falls under editing a zone rather than creating one.